Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6 #100

Open
alessiamarcolini opened this issue Nov 18, 2020 · 5 comments
Open

Drop support for Python 3.6 #100

alessiamarcolini opened this issue Nov 18, 2020 · 5 comments
Labels
dependencies Deps and Requirements

Comments

@alessiamarcolini
Copy link
Contributor

As Pandas recently dropped support for Python 3.6
pandas-dev/pandas#34472

@leriomaggio
Copy link
Member

👍 for me. I don't see reasons why we shouldn't.

@leriomaggio leriomaggio added the dependencies Deps and Requirements label Nov 19, 2020
@lorenz-gorini
Copy link
Member

lorenz-gorini commented Nov 19, 2020

Probably one of the main reasons of the original choice we did with Alessia was related to mlpy dependency inside dap/base.py in reference_interval repository.
I previously replaced the mlpy code in commit https://github.com/HK3-Lab-Team/reference_interval/commit/2bb5edc5197cf56584ec0f31874ef6fc1af8f5b5#diff-e808e08e43ff321cfbd3ccdef30c9c8a5f99d02faeb698f992c990bacb67c8f1 (and merged in PR https://github.com/HK3-Lab-Team/reference_interval/pull/6 ). So I do not see direct issues related to this. 🙏

@leriomaggio
Copy link
Member

No worries. However, mlpy support has to be dropped - effective immediately - in all the projects we do have.
Too much of a burden to carry, for No real benefit.

This has to happen gradually, of course; but the sooner, the better.

@lorenz-gorini
Copy link
Member

No worries to you too 😃. That was the only mlpy dependency we had in any project, and it is no longer present (https://github.com/HK3-Lab-Team/reference_interval/issues/1 )

@leriomaggio
Copy link
Member

Thanks Zeus for that! 🤙 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Deps and Requirements
Projects
None yet
Development

No branches or pull requests

3 participants