Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NaN columns to remove refactoring #1

Open
alessiamarcolini opened this issue Aug 31, 2020 · 2 comments
Open

NaN columns to remove refactoring #1

alessiamarcolini opened this issue Aug 31, 2020 · 2 comments

Comments

@alessiamarcolini
Copy link
Contributor

Why in https://github.com/HK3-Lab-Team/umapviz/blob/master/src/umapviz/umap_exp.py#L299 we are not using methods/properties of DataFrameWithInfo to get the columns to remove / to keep?

We could use least_nan_cols method (https://github.com/HK3-Lab-Team/pd_extras/blob/master/src/pd_extras/dataframe_with_info.py#L503) to not reimplement the calculation from scratch
@lorenz-gorini
Copy link
Member

You are right. I may had forgotten about that method and that I created it for that purpose when I rewrote the code. :(

@alessiamarcolini
Copy link
Contributor Author

No worries, let's write some tests before and then we can refactor it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alessiamarcolini @lorenz-gorini