Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMAP feature_weights refactoring #2

Open
alessiamarcolini opened this issue Aug 31, 2020 · 0 comments
Open

UMAP feature_weights refactoring #2

alessiamarcolini opened this issue Aug 31, 2020 · 0 comments

Comments

@alessiamarcolini
Copy link
Contributor

_get_feat_weights method of an UmapExperiment (https://github.com/HK3-Lab-Team/umapviz/blob/master/src/umapviz/umap_exp.py#L460) is called to get the feature weights, and in case self.feature_weights = () they are calculated and then the result is set to the feature_weights attribute and it is returned, too. Is that right?

If so, why not having a feature_weights property who calculates the result? If performance is a concern, we can cache the result so subsequent calls to the property won't trigger the calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant