Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n_neighbors and min_distance parameters of fit_transform of UmapExperiment #3

Open
alessiamarcolini opened this issue Aug 31, 2020 · 0 comments
Labels
invalid This doesn't seem right

Comments

@alessiamarcolini
Copy link
Contributor

Is there any good reason for the fit_transform method of UmapExperiment(https://github.com/HK3-Lab-Team/umapviz/blob/master/src/umapviz/umap_exp.py#L528) to accept n_neighbors and min_distance as parameters, considering that they are already set by the constructor of UmapExperiment? In case you want to change the value of them after an UmapExperiment is instantiated? Why not change the attribute of the instance directly and then call fit_transform?

This double chance to get the same result is causing me some confusion... also citing the Zen of Python: There should be one-- and preferably only one --obvious way to do it.

@alessiamarcolini alessiamarcolini added the invalid This doesn't seem right label Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant