You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there any good reason for the fit_transform method of UmapExperiment(https://github.com/HK3-Lab-Team/umapviz/blob/master/src/umapviz/umap_exp.py#L528) to accept n_neighbors and min_distance as parameters, considering that they are already set by the constructor of UmapExperiment? In case you want to change the value of them after an UmapExperiment is instantiated? Why not change the attribute of the instance directly and then call fit_transform?
This double chance to get the same result is causing me some confusion... also citing the Zen of Python: There should be one-- and preferably only one --obvious way to do it.
The text was updated successfully, but these errors were encountered:
Is there any good reason for the
fit_transform
method ofUmapExperiment
(https://github.com/HK3-Lab-Team/umapviz/blob/master/src/umapviz/umap_exp.py#L528) to acceptn_neighbors
andmin_distance
as parameters, considering that they are already set by the constructor ofUmapExperiment
? In case you want to change the value of them after anUmapExperiment
is instantiated? Why not change the attribute of the instance directly and then callfit_transform
?This double chance to get the same result is causing me some confusion... also citing the Zen of Python: There should be one-- and preferably only one --obvious way to do it.
The text was updated successfully, but these errors were encountered: