Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distance computation in umap_metrics.py #8

Open
lorenz-gorini opened this issue Sep 1, 2020 · 0 comments
Open

Fix distance computation in umap_metrics.py #8

lorenz-gorini opened this issue Sep 1, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@lorenz-gorini
Copy link
Member

In umap_metrics.py module many functions can be found with very similar purpose and naming.
For example gower_dist_numerical_old and gower_dist_numerical are different implementations meant to compute Gower distance between two vectors.
Similarly the module contains tanimoto_gower, tanimoto_gower_old and tanimoto_gower_no_bool_weights.

My proposal is to accurately check the appropriate algorithm that can compute tanimoto-gower distance in an efficient way, and verify its results with tests in test_metrics.py.

HINT: tanimoto_gower and gower_dist_numerical do not seem to be working perfectly, but according to previous comparisons, they seem to lead to better results.

@lorenz-gorini lorenz-gorini added the bug Something isn't working label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant