Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Representation for Pattern Matches #285

Closed
thtuerk opened this issue Aug 30, 2015 · 4 comments
Closed

New Representation for Pattern Matches #285

thtuerk opened this issue Aug 30, 2015 · 4 comments

Comments

@thtuerk
Copy link
Member

thtuerk commented Aug 30, 2015

As a follow-up on the ITP talk Pattern Matches in HOL: A New Representation and Improved Code Generation (slides, paper) there was a discussion moving the new pattern matching representation from examples/pattern_matches to somewhere in the src directory, so it is easier to use. It should be as early as possible and definitely be loaded by bossLib.

There are a few issues that need addressing, though. Most importantly, we need to come up with a new syntax for it and adapt the parsing and pretty printing. Then one needs to analyse dependencies and remove unnecessary ones in order to get it working early up in the build-process. Then tools need integrating in the standard tools like std_ss. Finally, we might want to add extra features and reimplement existing ones with the help of the new pattern matches. I will create separate issues for these points.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@thtuerk
Copy link
Member Author

thtuerk commented Sep 5, 2015

I just created a branch pattern_matches. The idea is to use that for performing the changes. I thought of roughly the following workflow:

  1. move pattern match example in src
    2a. adapt the parser ( @mn200 )
    2b. integrate with existing tools
  2. make sure that at least the src build works, better the examples as well
  3. merge with master
  4. add extra features

Points 2a and 2b are independent. I will start working on 1 and 2b now.

@mn200 is that plan OK?

@mn200
Copy link
Member

mn200 commented Sep 6, 2015

Looks great.

@thtuerk
Copy link
Member Author

thtuerk commented Jan 24, 2017

I believe this issue can be closed. The pmatch patterns are now integrated and documented. However, one could always add extra features. Therefore issue #289 is still open.

@mn200 please close this issue, if you agree.

@thtuerk
Copy link
Member Author

thtuerk commented Feb 14, 2017

Since there was no disagreement, I'm closing this issue now.

@thtuerk thtuerk closed this as completed Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants