-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AllCasePreds() #1164
Add AllCasePreds() #1164
Conversation
This is meant to be like AllCaseEqs(), but for the situation where the case statement occurs at the top level. Yong Kiam threatened he might use every_case_tac if there is no convenient way to do this.
Please add regression tests somewhere to exercise this code. To get your test a fairly rich context, maybe put something into |
I'm also a bit leery of repeatedly re-deriving all of the "elim" theorems each time; note how the |
If you'd prefer storing the theorems in the TypeBase I'm happy to do it like that; I just wasn't sure if it was worth it since this setup wasn't noticeably slow for me. But to be fair I haven't tested it in theories with many datatypes, or with many constructors yet. |
This avoids generating it on the fly in AllCasePreds().
@mn200 I believe I've addressed all your comments now. |
Thanks! |
This is meant to be like
AllCaseEqs()
, but for the situation where the case statement occurs at the top level.Yong Kiam threatened he might use
every_case_tac
if there is no convenient way to do this.