Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AllCasePreds() #1164

Merged
merged 7 commits into from
Nov 13, 2023
Merged

Add AllCasePreds() #1164

merged 7 commits into from
Nov 13, 2023

Conversation

IlmariReissumies
Copy link
Contributor

This is meant to be like AllCaseEqs(), but for the situation where the case statement occurs at the top level.

Yong Kiam threatened he might use every_case_tac if there is no convenient way to do this.

This is meant to be like AllCaseEqs(), but for the situation where
the case statement occurs at the top level.

Yong Kiam threatened he might use every_case_tac if there is no
convenient way to do this.
@mn200
Copy link
Member

mn200 commented Nov 10, 2023

Please add regression tests somewhere to exercise this code. To get your test a fairly rich context, maybe put something into src/boss/theory_tests, where you can see, for example caseEqAbbrevScript.sml.

@mn200
Copy link
Member

mn200 commented Nov 10, 2023

I'm also a bit leery of repeatedly re-deriving all of the "elim" theorems each time; note how the case_eq theorems are proved once and stored in the TypeBase.

@IlmariReissumies
Copy link
Contributor Author

I'm also a bit leery of repeatedly re-deriving all of the "elim" theorems each time; note how the case_eq theorems are proved once and stored in the TypeBase.

If you'd prefer storing the theorems in the TypeBase I'm happy to do it like that; I just wasn't sure if it was worth it since this setup wasn't noticeably slow for me. But to be fair I haven't tested it in theories with many datatypes, or with many constructors yet.

@IlmariReissumies
Copy link
Contributor Author

@mn200 I believe I've addressed all your comments now.

@mn200
Copy link
Member

mn200 commented Nov 13, 2023

Thanks!

@mn200 mn200 merged commit 667bb82 into develop Nov 13, 2023
2 checks passed
@mn200 mn200 deleted the bool_case branch November 13, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants