Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOL_ERR source locations #1342

Merged
merged 3 commits into from
Nov 15, 2024
Merged

HOL_ERR source locations #1342

merged 3 commits into from
Nov 15, 2024

Conversation

digama0
Copy link
Contributor

@digama0 digama0 commented Nov 15, 2024

This was mentioned as a TODO in Feedback.sml, and I need it for some error reporting work I'm doing. Adds a source_location field to error_record, and migrates most uses of the HOL_ERR constructor to either use incomplete pattern matching or mk_HOL_ERR instead.

@mn200
Copy link
Member

mn200 commented Nov 15, 2024

Looks good! Can merge when the CI is also good.

@binghe
Copy link
Member

binghe commented Nov 15, 2024

Looks good! Can merge when the CI is also good.

This time only OT build was successful:)

@mn200
Copy link
Member

mn200 commented Nov 15, 2024

Awesome: thanks!

@mn200 mn200 merged commit 833b239 into HOL-Theorem-Prover:develop Nov 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants