Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix or replace offline-plugin #4640

Open
derhuerst opened this issue Sep 22, 2022 · 5 comments
Open

fix or replace offline-plugin #4640

derhuerst opened this issue Sep 22, 2022 · 5 comments

Comments

@derhuerst
Copy link
Member

Follow-up of #4607.

offline-plugin doesn't work with Webpack 5 and seems unmaintained: NekR/offline-plugin#497

Personally, I haven't seen the offline caching work with digitransit-ui. Has someone seen it work recently?

@optionsome
Copy link
Member

Yes it does work but u have to edit https://github.com/HSLdevcom/digitransit-ui/blob/v2/app/buildInfo.js#L2 to make it work.

@derhuerst
Copy link
Member Author

Yes it does work but u have to edit […] to make it work.

Is that deployed somewhere?

@optionsome
Copy link
Member

Yes it does work but u have to edit […] to make it work.

Is that deployed somewhere?

https://reittiopas.hsl.fi/etusivu for example. Also, if I don't remember wrong, I think having a service worker was a requirement for PWAs to work.

@derhuerst
Copy link
Member Author

https://reittiopas.hsl.fi/etusivu for example.

Indeed, there is a service worker in place.

How do I check if the offline support works? When turning off my laptops internet connection and reloading, I can't use the Reittiopas website offline.

@optionsome
Copy link
Member

optionsome commented Sep 23, 2022

Indeed, there is a service worker in place.

How do I check if the offline support works? When turning off my laptops internet connection and reloading, I can't use the Reittiopas website offline.

Oh, I don't think it does work offline necessarily. The service worker is just there so we have more control over the caching behaviour and for the PWA support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants