-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a reloader to restart the controller #37
Comments
@Mec-iS for the front end to send a request to the server to reload the docs, I will need a POST method on |
I don't know if this is in-line with the spec, likely not. I suppose that creating a custom non-REST resource for the sake of the demo would be more appropriate. Probably finding a way to inject a |
I wrote a patch for the Flask app instance, which still will have to be called in Also I am really not sure how to update the vocabulary because:
@Mec-iS Any help? |
@xadahiya Please give a hint for the implementation ^ |
The main point here is we need a way to change the controller API structure efficiently ( can be done by the user or by autonomously after some time for the sake of the demo).
We'll need to modify hydrus a bit but since this is for the sake of demonstration and not the generic use case, it shouldn't be a problem. @Mec-iS thoughts? |
Sounds like a very neat and interesting approach.
I think it will work perfectly fine for some apiDoc changes (ie. Change in the path( For some other changes relating to class title and labels, property names ( or removal of classes or properties) besides changing the HydraDoc we will have to make changes in hydrus to modify the values stored in the database (Right now, these values are stored when we start the server and then remains unchanged). |
I don't think we need to modify class names and properties for this demo. |
@xadahiya I agree with not restarting the server via a POST request, but anyways you might want to have a look at this. I had submitted a PR modifying the UI to include an
A related discussion here. |
For sure we don't want to restart the machine, so possibly reloading the app or doing something with Python internals or even Python interpreter is the way to go. |
@xadahiya Ping #37 (comment) |
@invinciblycool This might work as well. The main thing to focus is we want to modify hydrus as minimum as possible for demo.
The central controller is just hydrus with a different vocab. Keep the main idea in mind i.e we need to demonstrate how powerful hydrus and semantic web is. For that, keeping the number of changes to the generic hydrus version is of utmost importance. Let's take some time to explore our options before we proceed with this else it'll just be a waste of time and we'll need to start over. |
This issue extends #137 in the hydrus repository.
Add a
reloader
which upon receiving the updated vocabulary from the UI, restarts the controller with the updated vocabulary.The text was updated successfully, but these errors were encountered: