Resource Hints 2021 query amends #2408
Conversation
| hint.name AS name, | ||
| hint.attribute AS attribute, | ||
| COUNTIF(hint.value IS NOT NULL) AS freq, | ||
| SUM(COUNT(0)) OVER (PARTITION BY _TABLE_SUFFIX, hint.name, hint.attribute) AS total, |
There was a problem hiding this comment.
Partitioning by everything in the GROUP BY is effectively the same as just COUNT(0). Did you mean to partition only by client and name?
There was a problem hiding this comment.
What is the total value you're going for, eg total number of instances per client/name/attribute combo? instances per client/name combo?
If the first one, I think SUM(COUNT(0)) OVER () is equivalent to COUNT(0) since there's only ever one count per combination to sum. If the second one, you'd need to remove the attribute from the partition.
There was a problem hiding this comment.
Thank you Rick. I have pushed an update with what I believe is the best implementation. Using client/name combo will show the number of times the attribute was used when the rel=preload per client.
Note that this query isn't very important and I only added it to substantiate my claim that imagesrcset isn't widely used.
rviscomi
added
analysis
…of preloads as denominator
Progress on #2158
consoleLog_missing_crossorigin.sqltoconsoleLog_incorrect_crossorigin.sqlconsoleLog_missing_crossorigin_type.sqltoconsoleLog_incorrect_crossorigin_type.sqlWHERE hints.preloadto consoleLog queries to only look at pages which have at least onerel="preload"imagesrcsetandimagesizesonrel="preload"