Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch camera extrinsic, camera pitch parameters to radians #1515

Open
4 tasks
tuxbotix opened this issue Nov 27, 2024 · 0 comments
Open
4 tasks

Switch camera extrinsic, camera pitch parameters to radians #1515

tuxbotix opened this issue Nov 27, 2024 · 0 comments
Labels
is:RecruitTask This has a limited scope and is therefore a good place to start for newbies. tools:Debug Tooling Related to twix et.al.

Comments

@tuxbotix
Copy link
Contributor

It was not nice to find that the units aren't consistant. At least we should add a suffix if we deviate from the conventions (i.e. extrinsic_rotations_deg or better to clean things up.

As I'm quite busy testing the calibration setup and working on fine tuning, someone else can do this, could also be a newbie task (with some helo) as the work itself isn't too hard.

TODOs:

  • Change manual & automatic calibration panels to save values in radians (while visualising in degrees for convenience
  • Change crates/control/src/camera_matrix_calculator.rs to read parameters as radians
  • ^Also check if we directly read the camera parameters elsewhere and modify them
  • Update the parameter JSON files! (some quick n dirty rust/ pythons script?)
@tuxbotix tuxbotix added is:RecruitTask This has a limited scope and is therefore a good place to start for newbies. tools:Debug Tooling Related to twix et.al. labels Nov 27, 2024
@tuxbotix tuxbotix moved this to Open in Development Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:RecruitTask This has a limited scope and is therefore a good place to start for newbies. tools:Debug Tooling Related to twix et.al.
Projects
Status: Open
Development

No branches or pull requests

1 participant