Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably duplicate CV Terms for ETciD and EThcD #285

Closed
caetera opened this issue Jun 18, 2024 · 4 comments · Fixed by #311
Closed

Probably duplicate CV Terms for ETciD and EThcD #285

caetera opened this issue Jun 18, 2024 · 4 comments · Fixed by #311

Comments

@caetera
Copy link
Contributor

caetera commented Jun 18, 2024

Describe the question or discussion

Using the current PSI-MS CV, ETci(hc)D fragmentation can be represented in two seemingly equivalent ways.
For example, for denoting ETciD it is possible to use MS:1003182, or a combination of MS:1000598 (ETD) and MS:1002679 (supplementary CID).

Is there any use case for supplementary CID/HCD outside ETciD/EThcD?
Is there any "correct" way to denote ETciD/EThcD and, if so, shouldn't the "wrong" way be marked as obsolete?

For further context, please, see the following discussions: OpenMS/OpenMS#7499 compomics/ThermoRawFileParser#182

@edeutsch
Copy link
Contributor

After some discussion on the PSI-MS call, we decide to move "combined dissociation method" so it is not a child of "dissociation method", which is not the best, but automatically disallows use of these two combined terms in mzML.

@mobiusklein
Copy link
Contributor

To add some more detail here from the discussion:

  1. The combined term names a "thing" that is used in the field and that is therefore something we want to keep in the controlled vocabulary.
  2. The combined term doesn't make it obvious to the reader how to interpret collision energies for the two parts, and implies that dissociation method combinations require explicit terms.

There isn't a way for the mzML validator to express a "may not" rule in the format it uses, in-so-far as I can tell, hence the re-parenting.

@caetera
Copy link
Contributor Author

caetera commented Jul 1, 2024

Thanks for looking into it. To confirm, two separate terms (for example, ETD + supplementary CID) should be used in mzML, while the combined terms (ETciD) are meant to be used for other applications, for example, SDRF.

@mobiusklein
Copy link
Contributor

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants