Add user sync functionality #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I (think I) implemented the Sync/UserSync functionality for the emulator. This is according to SFR_Rev4a.pdf page 12f.
My tests seem to show it working alright... clearly, it can't be relied upon as a hard timer, but for testing the functionality in general, it should be fine.
Since this is my first dabbling with something like an emulator for a 4-bit-cpu and my very first pull request ever, I'm very interested in everything I may have done wrongly or could have done better.
Also, thank you for this nice tool! The badge is a load of fun, and your emulator allowed for smooth progress when playing around with it, also it gave loads of insight in the inner workings where the manual wasn't quite enough to answer my questions.