Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell are not removing after view controllers deallocation. #45

Open
ShashikantBhadke opened this issue Sep 2, 2018 · 5 comments
Open

Comments

@ShashikantBhadke
Copy link

ShashikantBhadke commented Sep 2, 2018

Thanks for grate framework.
I found this issue when my collection view as well as tableview get deallocated then also cell of respective list are not removed from memory. I try to set collection view and tableview nil and removed from super view also in deinit method.
I have attached screenshot which is demo on which i also tried.
Thanks again😊🙂👍
screen shot 2018-08-31 at 12 08 24 pm

@itchix
Copy link

itchix commented Jul 25, 2019

Any update on this one? I have the same issue. I'm investigating this one without success for now.

@itchix
Copy link

itchix commented Jul 25, 2019

I did deallocate manually all delegate & datasource in the Tableview, and it seems to work :

open class TableView: UITableView {
    
    deinit {
        defaultTableFooterView = nil
        defaultDelegate = nil
        defaultDataSource = nil
        defaultTableHeaderView = nil
        dataSource = nil
        delegate = nil
        placeholderDelegate = nil
    }
...

⚠️ it's an HOTFIX, need to see why we should do that manually...

itchix added a commit to playmoweb/HGPlaceholders that referenced this issue Jul 25, 2019
@zeeshansuleman
Copy link

@itchix your solution did not work for me. cells are still residing in memory despite the call of dinit of collectionview and its respective controller.

@dimohamdy
Copy link

@itchix Thanks bro

@harshil-vyas08
Copy link

Hi
Still, I can face the same issue cells are not being deallocated from table view when there is no record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants