Fix angle, scale and origin on FlxStrip #2973
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geokureli
reviewed
Dec 18, 2023
Geokureli
reviewed
Dec 18, 2023
| if (angle != 0) | ||
| { | ||
| _cos = FlxMath.fastCos(angle * FlxAngle.TO_RAD); | ||
| _sin = FlxMath.fastSin(angle * FlxAngle.TO_RAD); |
There was a problem hiding this comment.
would you be willing to compare this with using Math.sin and cos to see if the lack of precision actually a noticeable difference, be sure to try angles > 360, too please
There was a problem hiding this comment.
I fixed the rest, but I'd still like you to test the precision of FastSin and cos
Geokureli
reviewed
Dec 18, 2023
Geokureli
reviewed
Dec 18, 2023
Geokureli
requested changes
Dec 18, 2023
Geokureli
reviewed
Dec 22, 2023
|
would these changes conflict with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.