Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SubcomponentPropsType to the actual props of the subcomponent #324

Open
aVileBroker opened this issue Sep 7, 2021 · 0 comments
Open
Labels
0.5 Story Points issue size: .5 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aVileBroker
Copy link
Contributor

The below example is too precise, as we want them to be able to add more than just the current props. Perhaps a union of the ComponentProps and SubcomponentPropsType.

Before:

skeletonProps?: SubcomponentPropsType;

After:

skeletonShimmerProps?: ComponentProps<typeof Skeleton.Shimmer>;
@aVileBroker aVileBroker added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed 0.5 Story Points issue size: .5 labels Sep 7, 2021
@breanna-eubanks breanna-eubanks self-assigned this Dec 23, 2021
@aVileBroker aVileBroker moved this to Todo in Foundry-React-UI Jan 12, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry-React-UI Jun 16, 2023
@aVileBroker aVileBroker reopened this Jun 26, 2023
@aVileBroker aVileBroker moved this from Done to Todo in Foundry-React-UI Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.5 Story Points issue size: .5 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants