Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interaction Feedback | Switch from useTransition to useSprings animations #401

Open
aVileBroker opened this issue Jun 20, 2022 · 0 comments
Open

Interaction Feedback | Switch from useTransition to useSprings animations #401

aVileBroker opened this issue Jun 20, 2022 · 0 comments
Assignees
@aVileBroker
Labels
1 Story Point Story points: 1 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aVileBroker
Copy link
Contributor

aVileBroker commented Jun 20, 2022 •
edited
Loading

Suggestion: switch from useTransition to useSprings animations
https://react-spring.io/hooks/use-springs#usesprings

We are already using random ids as keys for splashes, this should make keeping track of springs and deleting them work.

The result should be that the splashes stay on the screen and are more performant.
@aVileBroker aVileBroker added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed 1 Story Point Story points: 1 labels Jun 20, 2022
@aVileBroker aVileBroker moved this to In Progress in Foundry-React-UI Jan 12, 2023
@aVileBroker aVileBroker self-assigned this Jan 12, 2023
aVileBroker added a commit to aVileBroker/foundry-ui that referenced this issue Jan 12, 2023
@aVileBroker
fix(interaction feedback): rework of the udnerlying code for splashes
44b3a60 
This should fix the missing splashes on buttons, as well as improve performance

fixes Headstorm#401
@github-project-automation github-project-automation bot moved this from In Progress to Done in Foundry-React-UI Jun 16, 2023
@aVileBroker aVileBroker reopened this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aVileBroker aVileBroker

Labels
1 Story Point Story points: 1 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Foundry-React-UI
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aVileBroker