Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: widget does not contain CORS error handling #276

Open
fey opened this issue Jun 14, 2024 · 5 comments
Open

Bug: widget does not contain CORS error handling #276

fey opened this issue Jun 14, 2024 · 5 comments
Labels
bug Something isn't working frontend widget

Comments

@fey
Copy link
Collaborator

fey commented Jun 14, 2024

Summary

If we create a workspace, integrate the widget and try to use it on another domain, we will get an error in devtools, and the widget itself will not display anything

Reproduction steps

1. create a workspace
2. add the widget to your site with a domain that is not in the workspace
3. call the snippet and press send, see devtools

Expected result

the widget handles errors and displays them in a form

Actual result

No response on the form
image

Browsers

Chrome

OS

Linux

@fey fey added the bug Something isn't working label Jun 14, 2024
@bazilval
Copy link
Collaborator

В целом, думаю эти ишьюс связаны #249

@kitdim
Copy link
Contributor

kitdim commented Jun 20, 2024

Возьму

kitdim added a commit to kitdim/hexlet-correction that referenced this issue Jun 23, 2024
kitdim added a commit to kitdim/hexlet-correction that referenced this issue Jun 23, 2024
kitdim added a commit to kitdim/hexlet-correction that referenced this issue Jun 29, 2024
kitdim added a commit to kitdim/hexlet-correction that referenced this issue Jul 2, 2024
kitdim added a commit to kitdim/hexlet-correction that referenced this issue Jul 2, 2024
kitdim added a commit to kitdim/hexlet-correction that referenced this issue Jul 2, 2024
@niyatanya niyatanya changed the title Bug: виджет не содержит обработки CORS ошибок Bug: widget does not contain CORS error handling Jul 24, 2024
@Alena007S
Copy link

This error is still valid

  • summary:
    When trying to log in to a account with an invalid password, no error appears
    environment:
    Google Chrome
    ОС Windows
    steps-to-reproduce:
    1. open the login page https://hexlet-correction.herokuapp.com/login?error
    2. Enter the correct Email
    3. Enter incorrect Password
    4. Press Login button
    expected-result:
    Login was not successful.
    The message "Bad credential" appears
    actual-result:
    Login was not successful.
    But the message error does not appear
    147

@bazilval
Copy link
Collaborator

@Alena007S please make additional issue, cause this issue is about CORS error on widget

It will increase chances that someone fix that

@fey
Copy link
Collaborator Author

fey commented Aug 23, 2024

@kitdim can you take this task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend widget
Projects
None yet
Development

No branches or pull requests

4 participants