Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: When trying to log in to a account with an invalid password, no error appears #295

Open
Alena007S opened this issue Aug 12, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Alena007S
Copy link

Alena007S commented Aug 12, 2024

Summary

When trying to log in to a account with an invalid password, no error appears. This issue is about CORS error on widget

Reproduction steps

1. open the login page https://hexlet-correction.herokuapp.com/login?error
2. Enter the correct Email
3. Enter incorrect Password
4. Press Login button

Expected result

Login was not successful.
The message "Bad credentials" appears

Actual result

Login was not successful.
But the message error does not appear
147

Browsers

Chrome

OS

Windows

@Alena007S Alena007S added the bug Something isn't working label Aug 12, 2024
@fey fey added the good first issue Good for newcomers label Aug 27, 2024
@sergi-Jr
Copy link

Hi. Actually the “bad credential”
image
page gets in, but because “invalid-feedback” is applied strangely on the form there is no display (I'm not good at bootstrap css, but it seems to be the case).
I suggest not to remake the login page under invalid-feedback, but to return a working bootstrap alert message in the danger style. Especially this error indicates novalid password OR/AND email, so I think this would be a good solution.
It will look like this
image

What do you think?

@Ovsenka
Copy link

Ovsenka commented Sep 21, 2024

Hi. Actually the “bad credential” image page gets in, but because “invalid-feedback” is applied strangely on the form there is no display (I'm not good at bootstrap css, but it seems to be the case). I suggest not to remake the login page under invalid-feedback, but to return a working bootstrap alert message in the danger style. Especially this error indicates novalid password OR/AND email, so I think this would be a good solution. It will look like this image

What do you think?

Ok, looks good, i'll try fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants