Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround std::gcd and std::lcm constexpr issue #1019

Conversation

AlexanderSinn
Copy link
Member

It seems that std::gcd and std::lcm are not fully constexpr on some platforms, so this PR replaces the general formular with a simplified version that produces the same result, assuming that alignof(int) = 4 and alignof(amrex::Real) = 4 or 8.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added bug Something isn't working build CMake, compilation, etc. labels Sep 25, 2023
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! This was tested by a user and fixes the issue indeed.

@AlexanderSinn AlexanderSinn merged commit 5f6d395 into Hi-PACE:development Sep 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build CMake, compilation, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants