Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to limit number of buffered beam slices #1026

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Oct 11, 2023

This PR adds options

hipace.comms_buffer_max_leading_slices = 10
hipace.comms_buffer_max_trailing_slices = 10

to limit the amount of beam/laser slices that can be stored on any one rank. This is necessary for large beams/laser boxes that do not fit into the memory of a single rank as the fully asynchronous penalization without these parameters may put most of the data on to one rank. If the simulation has more timesteps than slices, then these parameters need to be set such that all ranks together can accommodate all slices to avoid a deadlock.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added component: beam About the beam species Parallelization Longitudinal and transverse MPI decomposition labels Oct 11, 2023
@MaxThevenet
Copy link
Member

Is this ready for review? If so, great! Could you add a description and show/discuss how it works and why it matters?

Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! See comments below.

docs/source/run/parameters.rst Outdated Show resolved Hide resolved
docs/source/run/parameters.rst Outdated Show resolved Hide resolved
docs/source/run/parameters.rst Outdated Show resolved Hide resolved
@MaxThevenet MaxThevenet merged commit a8e9a88 into Hi-PACE:development Nov 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: beam About the beam species Parallelization Longitudinal and transverse MPI decomposition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants