From 3ec65ed4e50fda8972d13285636779bd956ffa86 Mon Sep 17 00:00:00 2001 From: tarepan Date: Wed, 13 Nov 2024 10:07:14 +0900 Subject: [PATCH] =?UTF-8?q?=E8=BF=BD=E5=8A=A0:=20=E3=83=87=E3=83=95?= =?UTF-8?q?=E3=82=A9=E3=83=AB=E3=83=88=E3=83=97=E3=83=AA=E3=82=BB=E3=83=83?= =?UTF-8?q?=E3=83=88=E6=A9=9F=E8=83=BD=E3=82=92=E5=89=8A=E9=99=A4=E3=81=97?= =?UTF-8?q?=E3=83=97=E3=83=AA=E3=82=BB=E3=83=83=E3=83=88=E4=BF=9D=E5=AD=98?= =?UTF-8?q?=E5=85=88=E3=82=92=E6=8C=87=E5=AE=9A=E3=81=99=E3=82=8B=E6=A9=9F?= =?UTF-8?q?=E8=83=BD=E3=81=B8=E5=A4=89=E6=9B=B4=20(#1323)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .gitignore | 2 ++ Dockerfile | 2 +- presets.yaml | 12 ---------- run.py | 5 ++--- run.spec | 1 - test/e2e/conftest.py | 28 ++++++++++++++++++++++-- test/unit/preset/test_preset.py | 9 ++++---- tools/make_docs.py | 5 ++--- voicevox_engine/preset/preset_manager.py | 5 ++++- 9 files changed, 41 insertions(+), 28 deletions(-) delete mode 100644 presets.yaml diff --git a/.gitignore b/.gitignore index bfcae394d..70a8aa797 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,8 @@ ## Artifact of generating licenses /licenses.json licenses_venv/ +## Presets +presets.yaml # Copied from `https://github.com/github/gitignore/blob/main/Python.gitignore` @2022-01-10 # Byte-compiled / optimized / DLL files diff --git a/Dockerfile b/Dockerfile index 4ebdab3fd..d42733f1f 100644 --- a/Dockerfile +++ b/Dockerfile @@ -229,7 +229,7 @@ COPY --from=download-onnxruntime-env /opt/onnxruntime /opt/onnxruntime # Add local files ADD ./voicevox_engine /opt/voicevox_engine/voicevox_engine ADD ./docs /opt/voicevox_engine/docs -ADD ./run.py ./presets.yaml ./engine_manifest.json /opt/voicevox_engine/ +ADD ./run.py ./engine_manifest.json /opt/voicevox_engine/ ADD ./resources /opt/voicevox_engine/resources ADD ./tools/generate_licenses.py /opt/voicevox_engine/tools/ ADD ./tools/licenses /opt/voicevox_engine/tools/licenses diff --git a/presets.yaml b/presets.yaml deleted file mode 100644 index 6934b90d5..000000000 --- a/presets.yaml +++ /dev/null @@ -1,12 +0,0 @@ -- id: 1 - name: サンプルプリセット - speaker_uuid: 7ffcb7ce-00ec-4bdc-82cd-45a8889e43ff - style_id: 0 - speedScale: 1 - pitchScale: 0 - intonationScale: 1 - volumeScale: 1 - prePhonemeLength: 0.1 - postPhonemeLength: 0.1 - pauseLength: null - pauseLengthScale: 1 diff --git a/run.py b/run.py index 302f762f4..b17d29cae 100644 --- a/run.py +++ b/run.py @@ -360,11 +360,10 @@ def main() -> None: env_preset_path = Path(envs.env_preset_path) else: env_preset_path = None - root_preset_path = engine_root() / "presets.yaml" + default_preset_path = engine_root() / "presets.yaml" preset_path = select_first_not_none( - [args.preset_file, env_preset_path, root_preset_path] + [args.preset_file, env_preset_path, default_preset_path] ) - # ファイルの存在に関わらず指定されたパスをプリセットファイルとして使用する preset_manager = PresetManager(preset_path) use_dict = UserDictionary() diff --git a/run.spec b/run.spec index 7f3f7a1c9..0b70b71d1 100644 --- a/run.spec +++ b/run.spec @@ -7,7 +7,6 @@ datas = [ ('resources', 'resources'), ('engine_manifest.json', '.'), ('licenses.json', '.'), - ('presets.yaml', '.'), ] datas += collect_data_files('pyopenjtalk') diff --git a/test/e2e/conftest.py b/test/e2e/conftest.py index c70a12121..1cb36e879 100644 --- a/test/e2e/conftest.py +++ b/test/e2e/conftest.py @@ -4,6 +4,7 @@ from typing import Any import pytest +import yaml from fastapi import FastAPI from fastapi.testclient import TestClient @@ -35,8 +36,9 @@ def app_params(tmp_path: Path) -> dict[str, Any]: setting_loader = SettingHandler(tmp_path / "not_exist.yaml") # テスト用に隔離されたプリセットを生成する - preset_path = Path("./presets.yaml") - preset_manager = PresetManager(_copy_under_dir(preset_path, tmp_path)) + preset_path = tmp_path / "presets.yaml" + _generate_preset(preset_path) + preset_manager = PresetManager(preset_path) # テスト用に隔離されたユーザー辞書を生成する user_dict = UserDictionary( @@ -75,6 +77,28 @@ def client(app: FastAPI) -> TestClient: return TestClient(app) +def _generate_preset(preset_path: Path) -> None: + """指定パス下にプリセットファイルを生成する。""" + contents = [ + { + "id": 1, + "name": "サンプルプリセット", + "speaker_uuid": "7ffcb7ce-00ec-4bdc-82cd-45a8889e43ff", + "style_id": 0, + "speedScale": 1, + "pitchScale": 0, + "intonationScale": 1, + "volumeScale": 1, + "prePhonemeLength": 0.1, + "postPhonemeLength": 0.1, + "pauseLength": None, + "pauseLengthScale": 1, + } + ] + with open(preset_path, mode="w", encoding="utf-8") as f: + yaml.safe_dump(contents, f, allow_unicode=True, sort_keys=False) + + def _generate_user_dict(dir_path: Path) -> Path: """指定されたディレクトリ下にユーザー辞書ファイルを生成し、生成されたファイルのパスを返す。""" contents = { diff --git a/test/unit/preset/test_preset.py b/test/unit/preset/test_preset.py index 10f983b35..0efbfcfff 100644 --- a/test/unit/preset/test_preset.py +++ b/test/unit/preset/test_preset.py @@ -52,11 +52,10 @@ def test_empty_file() -> None: preset_manager.load_presets() -def test_not_exist_file() -> None: - preset_manager = PresetManager(preset_path=Path("test/presets-dummy.yaml")) - true_msg = "プリセットの設定ファイルが見つかりません" - with pytest.raises(PresetInternalError, match=true_msg): - preset_manager.load_presets() +def test_not_exist_file(tmp_path: Path) -> None: + preset_manager = PresetManager(preset_path=tmp_path / "presets-dummy.yaml") + presets = preset_manager.load_presets() + assert len(presets) == 0 def test_add_preset(tmp_path: Path) -> None: diff --git a/tools/make_docs.py b/tools/make_docs.py index 88eb55d14..e9483d0f0 100644 --- a/tools/make_docs.py +++ b/tools/make_docs.py @@ -47,6 +47,7 @@ def generate_api_docs_html(schema: str) -> str: core_manager.register_core(CoreAdapter(MockCoreWrapper()), "mock") tts_engines = TTSEngineManager() tts_engines.register_engine(MockTTSEngine(), "mock") + preset_path = engine_root() / "presets.yaml" engine_manifest = load_manifest(engine_manifest_path()) library_manager = LibraryManager( get_save_dir() / "installed_libraries", @@ -61,9 +62,7 @@ def generate_api_docs_html(schema: str) -> str: tts_engines=tts_engines, core_manager=core_manager, setting_loader=SettingHandler(USER_SETTING_PATH), - preset_manager=PresetManager( # FIXME: impl MockPresetManager - preset_path=engine_root() / "presets.yaml", - ), + preset_manager=PresetManager(preset_path), user_dict=UserDictionary(), engine_manifest=engine_manifest, library_manager=library_manager, diff --git a/voicevox_engine/preset/preset_manager.py b/voicevox_engine/preset/preset_manager.py index 32453441f..7029db043 100644 --- a/voicevox_engine/preset/preset_manager.py +++ b/voicevox_engine/preset/preset_manager.py @@ -29,10 +29,13 @@ class PresetManager: """ def __init__(self, preset_path: Path): - """プリセットの設定ファイルへのパスからプリセットマネージャーを生成する""" + """プリセットマネージャーを生成する。プリセットファイルが存在しない場合は新規作成する。""" + self.presets: list[Preset] = [] # 全プリセットのキャッシュ self.last_modified_time = 0.0 self.preset_path = preset_path + if not self.preset_path.exists(): + self.preset_path.write_text("[]") def _refresh_cache(self) -> None: """プリセットの設定ファイルの最新状態をキャッシュへ反映する"""