Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfml 3.0.0 #202104

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

sfml 3.0.0 #202104

wants to merge 4 commits into from

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Dec 22, 2024
@alebcay alebcay added the build failure CI fails while building the software label Dec 22, 2024
@daeho-ro daeho-ro force-pushed the bump-sfml-3.0.0 branch 3 times, most recently from c2f32ec to d4c74c9 Compare December 22, 2024 05:25
@iMichka
Copy link
Member

iMichka commented Dec 23, 2024

CMake Error at /opt/homebrew/Library/Homebrew/cmake/trap_fetchcontent_provider.cmake:12 (message):
Refusing to populate dependency 'Freetype' with FetchContent while building
in Homebrew, please use a formula dependency or add a resource to the
formula.
Call Stack (most recent call first):
/opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2468:EVAL:1 (trap_fetchcontent_provider)
/opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2468 (cmake_language)
/opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2314 (__FetchContent_MakeAvailable_eval_code)
src/SFML/Graphics/CMakeLists.txt:137 (FetchContent_MakeAvailable)
src/SFML/Graphics/CMakeLists.txt:153 (sfml_add_graphics_dependencies)

@iMichka iMichka force-pushed the bump-sfml-3.0.0 branch 2 times, most recently from e370767 to 59bf54e Compare December 23, 2024 22:25
@iMichka iMichka removed the build failure CI fails while building the software label Dec 23, 2024
@iMichka iMichka requested a review from chenrui333 December 23, 2024 22:35
@iMichka iMichka added the ready to merge PR can be merged once CI is green label Dec 23, 2024
@chenrui333 chenrui333 added in progress Stale bot should stay away and removed ready to merge PR can be merged once CI is green labels Dec 24, 2024
@ChrisThrasher
Copy link
Contributor

ChrisThrasher commented Dec 24, 2024

CMake Error at /opt/homebrew/Library/Homebrew/cmake/trap_fetchcontent_provider.cmake:12 (message): Refusing to populate dependency 'Freetype' with FetchContent while building in Homebrew, please use a formula dependency or add a resource to the formula. Call Stack (most recent call first): /opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2468:EVAL:1 (trap_fetchcontent_provider) /opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2468 (cmake_language) /opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2314 (__FetchContent_MakeAvailable_eval_code) src/SFML/Graphics/CMakeLists.txt:137 (FetchContent_MakeAvailable) src/SFML/Graphics/CMakeLists.txt:153 (sfml_add_graphics_dependencies)

SFML maintainer here! You can set SFML_USE_SYSTEM_DEPS to ON to bypass all this FetchContent stuff and fall back to find_package.

EDIT: I see this is already being used 👍🏻

@chenrui333
Copy link
Member

chenrui333 commented Dec 24, 2024

yeah, now we just need downstream API compatible patches.


@ChrisThrasher any chance to make a release for csfml to work with sfml v3?

saw the milestone tracker on it, https://github.com/SFML/CSFML/milestone/1

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 24, 2024
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed in progress Stale bot should stay away labels Dec 24, 2024
BrewTestBot and others added 2 commits December 24, 2024 18:08
Co-authored-by: Rui Chen <[email protected]>
Co-authored-by: Michka Popoff <[email protected]>
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants