Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoconf-archive: fix quoting of m4_fatal #202309

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Fixes #202234

@eli-schwartz
Copy link

eli-schwartz commented Dec 24, 2024

I suggest backporting all 3 patches from my upstream PR, as there are multiple macros that had regressions. However the project prefers to have one commit per macro so I had to divide them up. :)

Backporting only a single regression fix will fix libvisual but not fix other projects that use different macros instead.

@carlocab carlocab force-pushed the autoconf-archive-m4_fatal branch from 3e7b13a to 9640e17 Compare December 24, 2024 04:21
@carlocab
Copy link
Member Author

Thanks, done.

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 24, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 24, 2024
Merged via the queue into master with commit 1b37b58 Dec 24, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the autoconf-archive-m4_fatal branch December 24, 2024 06:28
hartwork added a commit to Libvisual/libvisual that referenced this pull request Dec 24, 2024
Homebrew started applying the patch itself by now:
Homebrew/homebrew-core#202309

This reverts commit 222b6c4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoconf-archive 2024.10.16 breaks important macro AX_CHECK_GL that was working with previous 2023.02.20
4 participants