Avoid unnecessary import (gin, gym) #1570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not always available
| @@ -172,6 +171,12 @@ def create_environment(env_name='CartPole-v0', | |||
|
|
|||
| """ | |||
|
|
|||
| if env_name is None: | |||
| env_name = 'CartPole-v0' | |||
There was a problem hiding this comment.
This seems to be the same as using CartPole-v0 as the default value for the argument env_name? Not sure if there is any particular reason for this change.
Haichao-Zhang
previously approved these changes
Dec 4, 2023
breakds
previously approved these changes
Dec 4, 2023
Haichao-Zhang
previously approved these changes
Dec 4, 2023
emailweixu
dismissed stale reviews from Haichao-Zhang and breakds
via
17bd976
emailweixu
force-pushed
the
PR_do_not_import_gin_gym
branch
from
c9f84bc to
17bd976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not always available.