From 66dc4599ca6081923b80254707176b20c0e29a3b Mon Sep 17 00:00:00 2001 From: Evan Wallace Date: Sun, 13 Dec 2015 19:35:42 +1100 Subject: [PATCH 1/3] Made HourglassII and HourglassIIUnity projects actually identical in configuration (apart from compiling different files). Eliminated warnings introduced by MSVC2015 Update 1. --- ide/msvc2015/HourglassII/HourglassII.sln | 2 +- .../HourglassII/HourglassII.vcxproj | 64 +++--- .../HourglassIIUnity/HourglassIIUnity.vcxproj | 204 +++++++++++++++++- 3 files changed, 232 insertions(+), 38 deletions(-) diff --git a/ide/msvc2015/HourglassII/HourglassII.sln b/ide/msvc2015/HourglassII/HourglassII.sln index 99ea9cfd..bc68e0fc 100644 --- a/ide/msvc2015/HourglassII/HourglassII.sln +++ b/ide/msvc2015/HourglassII/HourglassII.sln @@ -1,7 +1,7 @@  Microsoft Visual Studio Solution File, Format Version 12.00 # Visual Studio 14 -VisualStudioVersion = 14.0.23107.0 +VisualStudioVersion = 14.0.24720.0 MinimumVisualStudioVersion = 10.0.40219.1 Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "HourglassII", "HourglassII\HourglassII.vcxproj", "{6B51453F-145F-4852-936C-03D50D848279}" EndProject diff --git a/ide/msvc2015/HourglassII/HourglassII/HourglassII.vcxproj b/ide/msvc2015/HourglassII/HourglassII/HourglassII.vcxproj index 92382a11..1e7b8ae7 100644 --- a/ide/msvc2015/HourglassII/HourglassII/HourglassII.vcxproj +++ b/ide/msvc2015/HourglassII/HourglassII/HourglassII.vcxproj @@ -12,8 +12,8 @@ {6B51453F-145F-4852-936C-03D50D848279} - Win32Proj HourglassII + 8.1 @@ -32,21 +32,20 @@ - + - + - true + AllRules.ruleset false - NativeRecommendedRules.ruleset - false - NativeRecommendedRules.ruleset + AllRules.ruleset + false @@ -55,60 +54,71 @@ Disabled GLEW_BUILD;NOMINMAX;WIN32;_CRT_SECURE_NO_WARNINGS;_SCL_SECURE_NO_WARNINGS;BOOST_THREAD_VERSION=4;_DEBUG;_WINDOWS;_UNICODE%(PreprocessorDefinitions) true - - - - + + ..\..\..\..\ext\boost\include;..\..\..\..\ext\SFML\include;..\..\..\..\ext\tbb\include;%(AdditionalIncludeDirectories) - false - false false Strict + false true - 4100;4127;4191;4242;4265;4365;4371;4373;4514;4548;4571;4574;4619;4623;4625;4626;4647;4668;4710;4711;4800;4820;4886;4913;5026;5027 + 4100;4061;4127;4191;4242;4265;4365;4371;4373;4464;4514;4548;4571;4574;4619;4623;4625;4626;4647;4668;4710;4711;4800;4820;4886;4913;5026;5027;5031 + false Guard NotSet + false ProgramDatabase + true - Windows true $(SolutionDir)..\..\..\ext\boost\lib;$(SolutionDir)..\..\..\ext\SFML\lib;$(SolutionDir)..\..\..\ext\tbb\lib;%(AdditionalLibraryDirectories) sfml-graphics-d.lib;sfml-audio-d.lib;sfml-window-d.lib;sfml-system-d.lib;opengl32.lib;glu32.lib;winmm.lib;%(AdditionalDependencies) + Windows + + EnableAllWarnings - NotUsing Full true true - GLEW_BUILD;NOMINMAX;WIN32;_CRT_SECURE_NO_WARNINGS;_SCL_SECURE_NO_WARNINGS;BOOST_THREAD_VERSION=4;NDEBUG;_WINDOWS;_UNICODE;%(PreprocessorDefinitions) true - - - - + NotUsing + GLEW_BUILD;NOMINMAX;WIN32;_CRT_SECURE_NO_WARNINGS;_SCL_SECURE_NO_WARNINGS;BOOST_THREAD_VERSION=4;NDEBUG;_WINDOWS;_UNICODE;%(PreprocessorDefinitions) + + ..\..\..\..\ext\boost\include;..\..\..\..\ext\SFML\include;..\..\..\..\ext\tbb\include;%(AdditionalIncludeDirectories) - false Speed false Strict + false true - 4100;4127;4191;4242;4265;4365;4371;4373;4514;4571;4574;4619;4623;4625;4626;4647;4668;4710;4711;4800;4820;4886;4913;5026;5027 + 4100;4061;4127;4191;4242;4265;4365;4371;4373;4464;4514;4571;4574;4619;4623;4625;4626;4647;4668;4710;4711;4800;4820;4886;4913;5026;5027;5031 + false Guard NotSet + false + true - Windows true true true $(SolutionDir)..\..\..\ext\boost\lib;$(SolutionDir)..\..\..\ext\SFML\lib;$(SolutionDir)..\..\..\ext\tbb\lib;%(AdditionalLibraryDirectories) sfml-graphics.lib;sfml-audio.lib;sfml-window.lib;sfml-system.lib;opengl32.lib;glu32.lib;winmm.lib;%(AdditionalDependencies) + NotSet + Windows + UseLinkTimeCodeGeneration + + + + + + @@ -430,12 +440,6 @@ - - - - - - diff --git a/ide/msvc2015/HourglassII/HourglassIIUnity/HourglassIIUnity.vcxproj b/ide/msvc2015/HourglassII/HourglassIIUnity/HourglassIIUnity.vcxproj index 98331c9b..25c31a57 100644 --- a/ide/msvc2015/HourglassII/HourglassIIUnity/HourglassIIUnity.vcxproj +++ b/ide/msvc2015/HourglassII/HourglassIIUnity/HourglassIIUnity.vcxproj @@ -32,8 +32,6 @@ - - @@ -42,19 +40,20 @@ - NativeRecommendedRules.ruleset + AllRules.ruleset false - NativeRecommendedRules.ruleset + AllRules.ruleset false + NotUsing EnableAllWarnings Disabled - true GLEW_BUILD;NOMINMAX;WIN32;_CRT_SECURE_NO_WARNINGS;_SCL_SECURE_NO_WARNINGS;BOOST_THREAD_VERSION=4;_DEBUG;_WINDOWS;_UNICODE%(PreprocessorDefinitions) + true ..\..\..\..\ext\boost\include;..\..\..\..\ext\SFML\include;..\..\..\..\ext\tbb\include;%(AdditionalIncludeDirectories) @@ -62,12 +61,13 @@ Strict false true - 4100;4127;4191;4242;4265;4365;4371;4373;4514;4548;4571;4574;4619;4623;4625;4626;4647;4668;4710;4711;4800;4820;4886;4913;5026;5027 + 4100;4061;4127;4191;4242;4265;4365;4371;4373;4464;4514;4548;4571;4574;4619;4623;4625;4626;4647;4668;4710;4711;4800;4820;4886;4913;5026;5027;5031 false Guard NotSet false ProgramDatabase + true true @@ -85,6 +85,7 @@ true true true + NotUsing GLEW_BUILD;NOMINMAX;WIN32;_CRT_SECURE_NO_WARNINGS;_SCL_SECURE_NO_WARNINGS;BOOST_THREAD_VERSION=4;NDEBUG;_WINDOWS;_UNICODE;%(PreprocessorDefinitions) @@ -94,11 +95,12 @@ Strict false true - 4100;4127;4191;4242;4265;4365;4371;4373;4514;4571;4574;4619;4623;4625;4626;4647;4668;4710;4711;4800;4820;4886;4913;5026;5027 + 4100;4061;4127;4191;4242;4265;4365;4371;4373;4464;4514;4571;4574;4619;4623;4625;4626;4647;4668;4710;4711;4800;4820;4886;4913;5026;5027;5031 false Guard NotSet false + true true @@ -106,7 +108,9 @@ true $(SolutionDir)..\..\..\ext\boost\lib;$(SolutionDir)..\..\..\ext\SFML\lib;$(SolutionDir)..\..\..\ext\tbb\lib;%(AdditionalLibraryDirectories) sfml-graphics.lib;sfml-audio.lib;sfml-window.lib;sfml-system.lib;opengl32.lib;glu32.lib;winmm.lib;%(AdditionalDependencies) + NotSet Windows + UseLinkTimeCodeGeneration @@ -115,6 +119,192 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + CppHeader + + + CppHeader + + + CppHeader + + From a05d0020ca2f0f0a68503242daf8a2dfb96c9eaf Mon Sep 17 00:00:00 2001 From: Evan Wallace Date: Sun, 13 Dec 2015 19:37:08 +1100 Subject: [PATCH 2/3] Added *.VC.opendb to gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index bff70042..b555466a 100644 --- a/.gitignore +++ b/.gitignore @@ -6,6 +6,7 @@ /ide/msvc2015/HourglassII/HourglassII/x64 /ide/msvc2015/HourglassII/HourglassIIUnity/x64 +*.VC.opendb *.vcxproj.user *.vs *.sdf From 157818d5913550ab6b8633040a8b0e5c5810ce53 Mon Sep 17 00:00:00 2001 From: Evan Wallace Date: Sun, 13 Dec 2015 19:39:08 +1100 Subject: [PATCH 3/3] More warning elimination --- src/SimpleLuaCpp.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/SimpleLuaCpp.h b/src/SimpleLuaCpp.h index ead7baec..ca3c412d 100644 --- a/src/SimpleLuaCpp.h +++ b/src/SimpleLuaCpp.h @@ -11,6 +11,11 @@ #include #include namespace hg { + +#ifdef _MSC_VER +#pragma warning(push) +#pragma warning(disable : 4646) //[[noreturn]] declared with return type. Justified because `panic` has to be a lua_Cfunction, which returns int. +#endif [[noreturn]] inline int panic(lua_State *L) { //Check whether this is a memory allocation error LuaUserData &ud(getUserData(L)); @@ -24,6 +29,9 @@ namespace hg { boost::throw_exception(LuaError(L)); } } +#ifdef _MSC_VER +#pragma warning(pop) +#endif //RAII class for lua_State. //Movable but non-copyable, as I do not know