Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and refactor new reverse-box-collision code #6

Open
GoogleFrog opened this issue Dec 11, 2015 · 0 comments
Open

Check and refactor new reverse-box-collision code #6

GoogleFrog opened this issue Dec 11, 2015 · 0 comments

Comments

@GoogleFrog
Copy link
Contributor

Test the reverse box collision code. It appears to work.

The code is due to be refactored as the current implementation uses a boolean array and an array of boxes when the functions should now be passed a list of reverse boxes and a list of forwards boxes. Perhaps splitting up the list is unreasonable, the list could instead have list.iterator.nextReverse and list.iterator.nextForwards if that is a reasonable thing. In any case the structure of the current code is made fragile due to the naked boolean array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant