Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Threshold in scripts/internal_knowledge_preparation.py #27

Open
HarshSaini10 opened this issue Nov 5, 2024 · 1 comment
Open

Comments

@HarshSaini10
Copy link

According to the research paper, the following line : "We directly adopted the evaluator again for knowledge strips filtering, and the top-k is set to 5, filter threshold as -0.5", mentions that a threshold of -0.5 was used to filter the strips, but it is nowhere to be found in the internal_knowledge_preparation.py script.

@HuskyInSalt
Copy link
Owner

We chose the top-k filtering strategy in the repo. You can change the strategy by modifying the function select_relevants and setting the threshold. We will also update the second strategy later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants