New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed turbulence driving in ideal EOS and Added some new features - [opened] #549

Open

jmstone opened this issue Feb 7, 2024 · 1 comment

Labels

gitlab merge request

Collaborator

jmstone commented Feb 7, 2024

In GitLab by @woodyho13 on Feb 7, 2024, 03:53

Merges turb_driving_fix -> master

Changed Feature:

Fixed driving issue in Newtonian ideal EOS
Added Support for parabola driving profile (ref: Schmidt ea. (2006) Computers & Fluids 35 (2006) pp. 353–371.)
Added Support for impulsive driving

Changed Variables:

Added user input "dtdrive"/"parabola_driving" in block <turb_driving>
Added serval flags to identify the ideal eos

Collaborator Author

jmstone commented Mar 12, 2024

In GitLab by @rajsekhar1996 on Mar 12, 2024, 10:50

Commented on src/srcterms/turb_driver.cpp line 422

I think you should multiply kc with (2*PI/L) since kiso already has this factor included. Currently, the units of kiso and kc do not match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment