Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing C headers and replacing with Kokkos math functions, etc. #614

Open
felker opened this issue Nov 2, 2024 · 0 comments
Open

Comments

@felker
Copy link
Contributor

felker commented Nov 2, 2024

Leftover from #582. Besides the necessary omp.h, mpi.h, hip/hip_runtime.h, unistd.h, and sys/stat.h, I see the following C deprecated (since C++11) .h headers imported in src/:

  • math.h
  • float.h
  • stdio.h

I haven't searched comprehensively, but so far I havent found a case where the deprecated C headers are necessary or of missing coverage by a suitable Kokkos math function
fabs
. Generally you dont want to pollute global namespace, so even replacing stdio.h with cstdio would be preferable (vs. the even better Kokkos::printf or <iostream>).

Should double check that there are no GCC and/or CUDA compatibility issues, as raised in #582 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant