Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project assignment and improve project existence checks in subscr… #816

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix project assignment and improve project existence checks in subscr… #816

wants to merge 1 commit into from

Conversation

luigimolinaro
Copy link
Contributor

@luigimolinaro luigimolinaro commented Oct 18, 2024 •
edited
Loading

  • Added a check to verify whether the determined project (fs_project) exists and is accessible before attempting to list subscriptions. If the project cannot be accessed, an appropriate error message is displayed, and the script exits gracefully.
  • Add a check to very jq is present otherwise install (Debian and RH compatible)

@luigimolinaro luigimolinaro linked an issue Oct 18, 2024 that may be closed by this pull request
Syntax Error in cp4d-olm-fix.sh: Unexpected EOF and Unmatched Quotation Mark #806
Open
fketelaars
fketelaars requested changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@fketelaars fketelaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of removing the scripts to fix OLM. I have not seen a need for it since OCP 4.10.54. Do you believe the script is still valuable and should be retained?

@luigimolinaro
Copy link
Contributor Author

I agree with you, but having a "scripts" directory with useful tools isn't a bad idea.
You can delete the files whenever you want, but at least they're now improved and ready to use in the meantime without errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fketelaars fketelaars Awaiting requested review from fketelaars

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax Error in cp4d-olm-fix.sh: Unexpected EOF and Unmatched Quotation Mark
2 participants
@luigimolinaro @fketelaars