Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Model, Structured, Experiments, and Procurement Menus #9298

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Hide Model, Structured, Experiments, and Procurement Menus #9298

merged 7 commits into from
Dec 12, 2024

Conversation

MeSophie
Copy link
Contributor

@MeSophie MeSophie commented Dec 9, 2024

Fixes #9268
@rachelkg @rdstern I hided Model, Structured, experiments, and Procurement menus. Please have a look.

@rdstern
Copy link
Collaborator

rdstern commented Dec 9, 2024 •
edited
Loading

@MeSophie this isn't great.

Here is the view menu:
image

a) Please reinstate the Model Menu. It isn't there in View, so how can we ever get it back?
b) The other menus - the hidden ones (so not climatic) should presumably be unticked in the view menu? They are currently ticked the same as in Version 0.8.0, where they are visible.
c) When I change the ticking they should appear and disappear. Currently they don't seem to work. They work nicely in 0.8.0.

Currently this is a backward step.

So please also check your approach. It should be trivial, namely that our current default is to start R-Instat with the three items in the view menu ticked. Now we just want to start with them unticked.

@rdstern rdstern changed the title Hided Model, Structured, Experiments, and Procurement Menus Hide Model, Structured, Experiments, and Procurement Menus Dec 10, 2024
@MeSophie
Copy link
Contributor Author

@rdstern I hided Exprriments and Procurement menus using the View menu. Please have a look.

rdstern
rdstern previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now looks fine to me.
@N-thony over to you

N-thony
N-thony requested changes Dec 12, 2024
View reviewed changes
instat/frmMain.vb Outdated
@@ -595,6 +596,13 @@ Public Class frmMain
My.Application.Info.Version.Build.ToString()
End Sub

Public Sub SetHideMenus()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to set this sub Public instead of Private?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is solved.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still Public?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is solved

@N-thony N-thony merged commit fbcc184 into IDEMSInternational:master Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-thony N-thony N-thony approved these changes

@rdstern rdstern rdstern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hiding Structured and Procurement Menus upon opening
3 participants
@MeSophie @rdstern @N-thony