JOSS Paper

[mengqi-z]

Hi @lilyclements,

I have a few comments on the paper that need to be addressed before we proceed to the next stage:

1. Lines 52-53 duplicate the content from lines 49-51. I recommend removing lines 52-53 or merging with previous paragraph to avoid redundancy.

2. Usage Examples. On lines 62 and 67, please prepend carbonr:: to the functions to ensure consistency with the formatting used for other functions in the examples.

3. References.

   • For MacNeil et al., 2017. Please add the DOI: 10.1016/S2542-5196(17)30162-6
   • For Schmidt and Kulma, 2024. Please update the link to the appropriate DOI: 10.32614/CRAN.package.footprint

Thank you.

This issue is for JOSS paper review openjournals/joss-reviews#6932

[lilyclements]

Thank you @mengqi-z for this. It's very helpful. I have fixed this in PR #46. If you're happy with the changes then let me know and I will close this issue. Thanks.

[mengqi-z]

Thank you @lilyclements! I have one more thing I realized just now. Could you please add the city, country in the affiliation if possible? Thanks!

[lilyclements]

@mengqi-z thanks - have done (PR #48)

[mengqi-z]

Thanks! All looks good now!