Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Favicon override not showing, instead seeing default trefoil #2207

Closed
esmeetewinkel opened this issue Feb 20, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@esmeetewinkel
Copy link
Collaborator

esmeetewinkel commented Feb 20, 2024

Describe the bug
I tried including the custom favicon in the debug deployment (pointing it at master rather than the latest code release), following the instructions from #2192. However, I'm only able to see the default IDEMS trefoil icon, which was merged in #2203.

When opening the file config.ts in the debug deployment repo in VS Code, I see the problem Property 'favicon_asset' does not exist on type 'IDeploymentConfig'

App version
debug deployment v0.1.2.9

To Reproduce
Go to https://idems-debug.web.app/

Screenshots and videos
image

image image
@esmeetewinkel esmeetewinkel added the bug Something isn't working label Feb 20, 2024
@jfmcquade
Copy link
Collaborator

Woops, the changes merged to the debug deployment didn't reflect the up-to-date code from #2192.
See this new PR for the debug deployment config: IDEMSInternational/app-debug-content#51
And for experimenting locally, the property assignment is now with this line: config.web.favicon_asset = "images/icons/favicon.svg"; (note .web)

@esmeetewinkel
Copy link
Collaborator Author

Thanks @jfmcquade, working now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants