Sort autocomplete by Key instead of filter by Key #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #30.
This PR changes the auto-complete behaviour with respect to the "Attribute" value:
Now, we don't filter search results by Attribute but instead we sort the results by attribute.
This allows workflows like...
Enter
pax6
-> see a bunch of auto-complete results, pick "Antibody: pax6" to searchNow we want to do a different search for
pax6
- this time the auto-complete still shows e.g. "Gene Symbol: pax6" so we can pick that and search.We still sort by Key, so if you choose "Antibody" and
pax
, you will seeAntibody
results first.But if you happen to enter
pax8
, you won't see no results - instead you'll get: