Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort autocomplete by Key instead of filter by Key #31

Merged
merged 1 commit into from
May 24, 2023

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Mar 29, 2023

See #30.

This PR changes the auto-complete behaviour with respect to the "Attribute" value:

Now, we don't filter search results by Attribute but instead we sort the results by attribute.

This allows workflows like...

  • Enter pax6 -> see a bunch of auto-complete results, pick "Antibody: pax6" to search

  • Now we want to do a different search for pax6 - this time the auto-complete still shows e.g. "Gene Symbol: pax6" so we can pick that and search.

  • We still sort by Key, so if you choose "Antibody" and pax, you will see Antibody results first.

Screenshot 2023-03-29 at 10 56 48

But if you happen to enter pax8, you won't see no results - instead you'll get:

Screenshot 2023-03-29 at 11 01 31

@will-moore will-moore requested a review from francesw March 30, 2023 08:50
@will-moore
Copy link
Member Author

This is now deployed on idr-testing. cc @francesw

Copy link
Member

@francesw francesw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on idr-testing, works well.

@pwalczysko
Copy link

LGTM

@sbesson
Copy link
Member

sbesson commented Apr 3, 2023

Is this meant to get released with prod115? If so, we'll need a release of the app and a PR against IDR/deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants