New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspect setMaxCartesianVelocity ought to actually call the service #304

Open

MShields1986 opened this issue Mar 21, 2024 · 0 comments

MShields1986 commented Mar 21, 2024

Hello,
Many thanks for your work on the package.
I've been trying to leverage some of the features and suspect that the code here...

bool PathParametersLinService::setMaxCartesianVelocity(const geometry_msgs::Twist max_cartesian_velocity) {
  config_.request.max_cartesian_velocity = max_cartesian_velocity;
}

...ought to be...

bool PathParametersLinService::setMaxCartesianVelocity(const geometry_msgs::Twist max_cartesian_velocity) {
  config_.request.max_cartesian_velocity = max_cartesian_velocity;
  return callService();
}

...but maybe I'm missing something?

MShields1986 mentioned this issue

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment