Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automatic deployment to docker #109

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Fix automatic deployment to docker #109

merged 2 commits into from
Feb 6, 2024

Conversation

leavauchier
Copy link
Collaborator

@leavauchier leavauchier commented Feb 5, 2024 •
edited
Loading

  • Fix path to docker registry
  • Update deprecated actions / variable storage

@CharlesGaydon FYI docker deployment is only done on push on the main or a staging-* branch

@leavauchier leavauchier force-pushed the fix-deployment branch 3 times, most recently from 38e2bd9 to 1f1f0e4 Compare February 5, 2024 16:14
CharlesGaydon
CharlesGaydon approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@CharlesGaydon CharlesGaydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@leavauchier leavauchier merged commit d1a8424 into main Feb 6, 2024
2 checks passed
@leavauchier leavauchier deleted the fix-deployment branch February 6, 2024 10:42
@CharlesGaydon CharlesGaydon mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesGaydon CharlesGaydon CharlesGaydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leavauchier @CharlesGaydon