Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Mute Unmute Issue on Entity and Council Page #365

Merged
merged 10 commits into from
Jan 14, 2023

Conversation

Shubham9455
Copy link

@Shubham9455 Shubham9455 commented Jan 6, 2023

In this PR I am solving the following issues:

  • mute/unmute on Entity and Council Page
  • PORs on ProfilePage
  • Clickable Events and workshop tab on clubs page
screen-recorder-tue-jan-10-2023-15-04-34.webm

WhatsApp.Video.2023-01-06.at.11.53.13.PM.mp4

@Aadeesh11
Copy link
Member

Aadeesh11 commented Jan 10, 2023

Thanks for raising a PR @Shubham9455 !
I see a bug:

  1. Sliding panel's topics (for eg: workshops and events on club's page) are not tappable. To change a topic you have to swipe across the screen.
    Can you make them tappable so that it is easy to switch between topics?

After solving this just request a review either from me or @ItsAdityaKSingh.

@Shubham9455
Copy link
Author

Shubham9455 commented Jan 10, 2023

Thanks for raising a PR @Shubham9455 ! I see a bug:

1. Sliding panel's topics (for eg: workshops and events on club's page) are not tappable. To change a topic you have to swipe across the screen.
   Can you make them tappable so that it is easy to switch between topics?

After solving this just request a review either from me or @ItsAdityaKSingh.

I solved the bug you mentioned on clubs page.
@Aadeesh11 @ItsAdityaKSingh Please Review this PR

@ItsAdityaKSingh
Copy link
Member

@Shubham9455 any update on the above review from @nb9960?

@Shubham9455
Copy link
Author

Shubham9455 commented Jan 12, 2023

@Shubham9455 any update on the above review from @nb9960?

@ItsAdityaKSingh
Yes, we discussed and concluded that Removing the mute-unmute option from the council page is the only way to resolve the issue until we change it from backend, if you have any other ideas then please suggest else I will push changes in my next commit

@Shubham9455 Shubham9455 requested review from nb9960 and removed request for Aadeesh11, ItsAdityaKSingh and devansh12b2 January 12, 2023 18:05
@ItsAdityaKSingh
Copy link
Member

Thanks for the PR @Shubham9455 🚀 LGTM!

@ItsAdityaKSingh ItsAdityaKSingh merged commit cf9a613 into IIT-BHU-InstiApp:dev Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants