Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs for cleaning up the repository #12

Open
4 of 7 tasks
porst17 opened this issue Mar 5, 2018 · 0 comments
Open
4 of 7 tasks

TODOs for cleaning up the repository #12

porst17 opened this issue Mar 5, 2018 · 0 comments

Comments

@porst17
Copy link
Member

porst17 commented Mar 5, 2018

It has to be discussed what makes sense and when we should do it. Better have a list then forgetting it.

  • turn the main Kiosk functionality into an npm package that can be utilized by other Electron applications (like, e.g. the SNAPSHOT-Slider).
  • separate the test app from the Kiosk browser
  • clean up the index.html page - maybe join it with the test app
  • separate the menu from the main.js file
  • move the yargs parsing out of the apps ready event handler because certain Chrome options are set inside the handler even though they should be set beforehand (according to the Electron doc)
    • find a way to read the default settings before the ready event. The currently used package electron-settings only works after ready has been emitted, but then we couldn't use the defaults with yargs
  • restructure the repository: currently everything is under images/kiosk due to its previous location in another repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant