Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-channel signals. Modify Trace shape or create a new shape? #195

Open
apdavison opened this issue Oct 1, 2018 · 1 comment
Open
Assignees
Labels

Comments

@apdavison
Copy link
Member

A request for feedback:

I need to represent multi-channel electrophysiology data. This could be done either by modifying the existing Trace shape or by creating a new shape for multi-channel data, leaving Trace specific for single-channel data.

Any thoughts on the best approach?

@annakristinkaufmann
Copy link
Collaborator

Thanks for your question, @apdavison ! My feeling is that it would be most appropriate to use the Trace shape to describe shared property shapes between all traces and hence to create more specialised shapes for multi-channel electrophysiology data as well as single-unit electrophysiology recordings. Maybe you could come up with a proposal for the multi-channel trace shape? We could take care of the refactoring of the existing Trace shape to remove the property shapes which are specific to the single-unit recording use case. What do you think, @MFSY ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants