Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear lines in CMakeLists #301

Open
mohsensadr opened this issue Jun 12, 2024 · 1 comment
Open

Unclear lines in CMakeLists #301

mohsensadr opened this issue Jun 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working cleanup

Comments

@mohsensadr
Copy link
Member

What is the purpose of adding -G when compiling for CUDA? CMAKE_CXX_FLAGS_DEBUG seems to include -g flag.

Trying to include -G, I get errors like

[  5%] Building CXX object _deps/heffte-build/CMakeFiles/Heffte.dir/src/heffte_c.cpp.o
cd /data/user/sadr_m/ippl/build_cuda/_deps/heffte-build && /data/user/sadr_m/ippl/build_cuda/_deps/kokkos-src/bin/kokkos_launch_compiler /data/user/sadr_m/ippl/build_cuda/_deps/kokkos-src/bin/nvcc_wrapper /opt/psi/Programming/gcc/12.3.0/bin/g++ /opt/psi/Programming/gcc/12.3.0/bin/g++ -DENABLE_FFT -DUSE_ALTERNATIVE_VARIANT -I/data/user/sadr_m/ippl/build_cuda/_deps/heffte-build/include -isystem /data/user/sadr_m/ippl/build_cuda/_deps/heffte-src/include -g -fsanitize=address,undefined -G -Wunused -Wno-deprecated-declarations -Wno-stringop-overflow -Wno-array-bounds -Wno-restrict -pthread -std=c++20 -MD -MT _deps/heffte-build/CMakeFiles/Heffte.dir/src/heffte_c.cpp.o -MF CMakeFiles/Heffte.dir/src/heffte_c.cpp.o.d -o CMakeFiles/Heffte.dir/src/heffte_c.cpp.o -c /data/user/sadr_m/ippl/build_cuda/_deps/heffte-src/src/heffte_c.cpp
g++: error: unrecognized command-line option ‘-G’

Also, Kokkos_DEVICES is empty in the current approach of compiling IPPL with cmake.

https://github.com/IPPL-framework/ippl/blob/db2ea88807363cbd9aaf083b872aaf78abe99132/CMakeLists.txt#L130C1-L132C8

@aaadelmann
Copy link
Member

-G is for generating shared objects. I would just remove this, we do not want to have shared object .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup
Projects
None yet
Development

No branches or pull requests

5 participants