Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timing issue in FilesRepository.test.ts #101

Closed
ekraffmiller opened this issue Oct 31, 2023 · 1 comment · Fixed by #104
Closed

Timing issue in FilesRepository.test.ts #101

ekraffmiller opened this issue Oct 31, 2023 · 1 comment · Fixed by #104
Assignees
@MellyGray
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 10 A percentage of a sprint. 7 hours.

Comments

@ekraffmiller
Copy link
Contributor

ekraffmiller commented Oct 31, 2023 •
edited by GPortas
Loading

Because of a timing issue, sometimes the integration test for FilesRepository fails, due to an OptimisticLockException. This is happening in my local environment, but not in the Github action. I tried it in the develop branch, and also https://github.com/IQSS/dataverse-client-javascript/tree/95-get-dataset-locks.

Edit (11/01) - Guillermo:

The error also occurs in the GitHub action:
https://github.com/IQSS/dataverse-client-javascript/actions/runs/6719463036/job/18261139350

From PR: #99

Edit (11/02) - Guillermo:

I have a failure also on my localhost.

To reproduce, build the library then run:
npm run test:integration

Attached is the error output:
error.txt
@GPortas GPortas mentioned this issue Nov 2, 2023
Merged
GPortas added a commit that referenced this issue Nov 2, 2023
@GPortas
Added: skipping FilesRepository IT temporarily due to reported issue #…
a8f9bb5 
…101
@GPortas
Copy link
Contributor

GPortas commented Nov 2, 2023

I've decided to temporarily skip this test in the code until we fix it to avoid breaking the package build and GPR push in the GitHub action @ekraffmiller.

@GPortas GPortas added Size: 10 A percentage of a sprint. 7 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Nov 22, 2023
@GPortas GPortas moved this to Re-arch: SPA MVP (Guillermo) in IQSS Dataverse Project Nov 27, 2023
@GPortas GPortas moved this from Re-arch: SPA MVP (Guillermo) to SPRINT READY in IQSS Dataverse Project Nov 27, 2023
@GPortas GPortas moved this from SPRINT READY to Clear of the Backlog in IQSS Dataverse Project Nov 27, 2023
@MellyGray MellyGray self-assigned this Nov 29, 2023
@MellyGray MellyGray linked a pull request Nov 29, 2023 that will close this issue
101 - Fix timing issue in FileRepository integration tests #104
Merged
@MellyGray MellyGray mentioned this issue Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MellyGray MellyGray

Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 10 A percentage of a sprint. 7 hours.
Projects
IQSS Dataverse Project
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

101 - Fix timing issue in FileRepository integration tests IQSS/dataverse-client-javascript
3 participants
@ekraffmiller @GPortas @MellyGray