Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file creation date and publication date in FileModel from date object to string type #223

Open
ChengShi-1 opened this issue Nov 18, 2024 · 0 comments · May be fixed by #226
Open
Labels
FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Page SPA.Q4.10 Resolve TODOs and tech debt

Comments

@ChengShi-1
Copy link
Contributor

ChengShi-1 commented Nov 18, 2024

What inspired the request?
This issue is inspired when I found that once the file uploaded, it was always saved as midnight 12:00 AM UTC, regardless of the hour, and 12:00 AM UTC was as 7:00 PM EST on the previous day (my local time zone). This discrepancy caused the file date in the front-end page, followed users' local timezone, to appear a day earlier than the intended date. For example, I uploaded the file Nov. 14 would be saved Nov.14 12:00 AM UTC, but shown Nov. 13 locally due to a conversion from UTC to EST.

Overview of the Feature Request
We discussed on the weekly update meeting Nov. 21st for this issue, and decided to keep the string type from backend api endpoint as it was, rather than converting to the date object with timestamp, for file's creationDate and publicationDate. Since there are possible time zone conflict for the citation usage, it's better to keep the date fixed and constant for all users in different location.

Change the date object in FileModel for file creation date and publication date to string, and handle it as a string for all related components.

@ChengShi-1 ChengShi-1 added Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q4.10 Resolve TODOs and tech debt labels Nov 18, 2024
@ChengShi-1 ChengShi-1 transferred this issue from IQSS/dataverse Nov 21, 2024
@ChengShi-1 ChengShi-1 changed the title add a "Time" field into file date object Change file creation date and publication date in FileModel from date object to string type Nov 21, 2024
@ChengShi-1 ChengShi-1 added the FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) label Nov 21, 2024
@ChengShi-1 ChengShi-1 moved this to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Nov 21, 2024
@ChengShi-1 ChengShi-1 self-assigned this Dec 4, 2024
@ChengShi-1 ChengShi-1 moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Dec 4, 2024
@ChengShi-1 ChengShi-1 removed their assignment Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Page SPA.Q4.10 Resolve TODOs and tech debt
Projects
Status: 🔍 Interest
1 participant