Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getFileThumbnailById implementation to use authentication #195

Open
MellyGray opened this issue Oct 10, 2023 · 1 comment
Open

Update getFileThumbnailById implementation to use authentication #195

MellyGray opened this issue Oct 10, 2023 · 1 comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows

Comments

@MellyGray
Copy link
Contributor

Overview of the Feature Request

We need to update the implementation of the getFileThumbnailById method of the FileJSDataverseRepository to incorporate authentication. This update is necessary once the Data Access API is enhanced to support new authentication methods (currently it is using cookie authentication)

What kind of user is the feature intended for?

All of them

What inspired the request?

The inspiration behind this feature request is to enhance security and access control for the getFileThumbnailById functionality. With the introduction of new authentication methods in the Access Data API, it is essential to align the getFileThumbnails implementation accordingly to ensure secure access to file thumbnails.

What existing behavior do you want changed?

Currently, the getFileThumbnails function does not utilize authentication when retrieving file thumbnails. The Access Data API is using the cookie authentication by default, but this would be removed in the future, so in that moment we'll need to update the SPA implementation.

Any brand new behavior do you want to add to Dataverse?

Modify the getFileThumbnails implementation to incorporate authentication based on the updated Access Data API.

With this feature, the getFileThumbnails function will use the latest authentication methods provided by the Access Data API to ensure that only authorized users can access file thumbnails.

Any open or closed issues related to this feature request?

@MellyGray MellyGray added pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Oct 10, 2023
@MellyGray MellyGray moved this to Re-arch: SPA MVP (Guillermo) in IQSS Dataverse Project Oct 10, 2023
@qqmyers
Copy link
Member

qqmyers commented Oct 10, 2023

FYI: #9669 makes several changes w.r.t. thumbnails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows
Projects
None yet
Development

No branches or pull requests

2 participants