Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Aqua tests and Project files #3

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix Aqua tests and Project files #3

merged 2 commits into from
Dec 4, 2024

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Dec 4, 2024

This resolves the complaints of Aqua about stale dependencies:

  • remove the test/Project.toml since these dependencies are defined in the main Project.toml
  • remove Aqua from the [deps], since it is only a test dependency and should thus only be in [extras]

@mtfishman mtfishman closed this Dec 4, 2024
@mtfishman mtfishman reopened this Dec 4, 2024
@ogauthe
Copy link
Collaborator

ogauthe commented Dec 4, 2024

Thanks @lkdvos !

@ogauthe ogauthe merged commit 4cc3ccb into main Dec 4, 2024
10 checks passed
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (e84b799) to head (3763964).
Report is 2 commits behind head on main.

Additional details and impacted files
@@    Coverage Diff    @@
##   main   #3   +/-   ##
=========================
=========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkdvos lkdvos deleted the ld-aqua branch December 4, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants