Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define map_blocklabels #5

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Define map_blocklabels #5

merged 2 commits into from
Dec 16, 2024

Conversation

ogauthe
Copy link
Contributor

@ogauthe ogauthe commented Dec 16, 2024

This PR defines map_blocklabels as a GradedUnitRanges function. It is used to define flip, and removes the need for label_dual.

The next step is to remove map_blocklabels from SymmetrySectors, where it does not belong.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@4f628c4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/gradedunitrangedual.jl 50.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage        ?   76.08%           
=======================================
  Files           ?        8           
  Lines           ?      368           
  Branches        ?        0           
=======================================
  Hits            ?      280           
  Misses          ?       88           
  Partials        ?        0           
Flag Coverage Δ
docs 0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman changed the title define map_blocklabels Define map_blocklabels Dec 16, 2024
@mtfishman
Copy link
Member

Looks good, thanks!

@mtfishman mtfishman merged commit 625665d into ITensor:main Dec 16, 2024
11 checks passed
@mtfishman
Copy link
Member

mtfishman commented Dec 16, 2024

@ogauthe can you bump the version to v0.1.1 and register a new version? (I think as a practice we should do that for every PR, though of course we would bump the minor version if there are breaking changes.)

@ogauthe ogauthe mentioned this pull request Dec 17, 2024
@ogauthe ogauthe deleted the map_blocklabels branch December 17, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants