From 499a616c076659c28704e774faf9345b4c08a18a Mon Sep 17 00:00:00 2001 From: Karl Pierce Date: Sun, 8 Oct 2023 13:36:15 -0400 Subject: [PATCH] Print warning because they do work when scalar allowed --- NDTensors/src/linearalgebra/linearalgebra.jl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/NDTensors/src/linearalgebra/linearalgebra.jl b/NDTensors/src/linearalgebra/linearalgebra.jl index ab52e658f5..000cc8f7bd 100644 --- a/NDTensors/src/linearalgebra/linearalgebra.jl +++ b/NDTensors/src/linearalgebra/linearalgebra.jl @@ -423,8 +423,8 @@ matrix is unique. Returns a tuple (Q,R). """ function qr_positive(M::AbstractMatrix) if iscu(M) - throw( - "Currently qr positive methods do not work for CuArrays because they require scalar operations. Please convert to CPU Array or use generic qr", + println( + "WARNING!!: Currently qr positive methods are not efficient for CuArrays because they require scalar operations. Please convert to CPU Array or use generic qr", ) end sparseQ, R = qr(M) @@ -453,8 +453,8 @@ matrix is unique. Returns a tuple (Q,L). """ function ql_positive(M::AbstractMatrix) if iscu(M) - throw( - "Currently ql positive methods do not work for CuArrays because they require scalar operations. Please convert to CPU Array or use generic ql", + println( + "WARNING!! Currently the ql positive methods are not efficient for CuArrays because they require scalar operations. Please convert to CPU Array or use generic ql", ) end sparseQ, L = ql(M)