Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDTensors][ITensors] Refactor BlockSparse system #1129

Closed
wants to merge 347 commits into from

Conversation

kmp5VT
Copy link
Collaborator

@kmp5VT kmp5VT commented May 30, 2023

Description

The goal of this PR is to refactor the BlockSparse system. A few things will go into this refactor: 1. I will be organizing the code to match the previous NDTensors refactors, 2. I will be working to make a more understandable and documented blocking system in ITensors, 3. I will be working to make the BlockSparse system stand-alone from the ITensors package, 4. I will be updating the blockoffset system to utilize either Tensors or StorageTypes which will allow more flexibility in the sparsity of these Tensors.

This PR is based on #1097

Checklist:

  • My code follows the style guidelines of this project. Please run using JuliaFormatter; format(".") in the base directory of the repository (~/.julia/dev/ITensors) to format your code according to our style guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that verify the behavior of the changes I made.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.

kmp5VT added 30 commits April 7, 2023 13:32
… v"1.8" and lower this will disable NDTensorCUDA
… to this repo instead of constructing a new one (like it does in the repl)
@mtfishman
Copy link
Member

@kmp5VT can this be closed? We will be moving to the BlockSparseArray type anyway.

@mtfishman mtfishman closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants