[Debug][NDTensors] Unwrap reshapedArray function #1155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ites back to original tensor
mtfishman
reviewed
Jul 20, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1155 +/- ##
===========================================
- Coverage 85.28% 54.26% -31.02%
===========================================
Files 87 86 -1
Lines 8368 8314 -54
===========================================
- Hits 7137 4512 -2625
- Misses 1231 3802 +2571 |
|
Superseded by other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently reshapedarrays with non-CPU backend do not work properly in the mul! function (they are considered CPU arrays and
BLAS.gemm!is called on them which results in an addressing error) Created a simple function which unwraps the ReshapedArrays computes the gemm and then rewrites the data back to the correct piece of memory. This is especially important in views.